Skip to content

Add databricks-serverless-storage-check skill#82

Open
GabbysCode wants to merge 6 commits into
databricks:mainfrom
GabbysCode:add-serverless-storage-check
Open

Add databricks-serverless-storage-check skill#82
GabbysCode wants to merge 6 commits into
databricks:mainfrom
GabbysCode:add-serverless-storage-check

Conversation

@GabbysCode

@GabbysCode GabbysCode commented May 20, 2026

Copy link
Copy Markdown

Summary

  • Adds databricks-serverless-storage-check as a nested sub-skill under skills/databricks-serverless-migration/, detecting cross-task local-disk (/local_disk0/tmp) handoffs that silently fail in Databricks Serverless
  • Skill covers 6 fanout patterns (FANOUT001–FANOUT006) and 1 environment pattern (ENV001), with severity scoring and remediation paths (UC Volumes, /Workspace, taskValues, pipeline_task)
  • Reference docs consolidated into a single skills/databricks-serverless-migration/references/serverless-storage-check.md (pattern catalog + remediation guide) matching parent skill structure
  • Removed redundant agents/openai.yaml and assets/ from sub-skill dir (inherited from parent)
  • Wired into plugin infra: metaplugin/plugin.meta.json skills map, scripts/skillsgen/discovery.py nested sub-skill discovery, all four provider bundles regenerated
  • Rebased onto upstream main (post-generator-refactor: scripts/skills.py façade, scripts/skillsgen/ package, metaplugin/plugin.meta.json)
  • stf lint passes on all 4 ground_truth.yaml test cases; python3 scripts/skills.py validate passes clean

Test plan

  • python3 scripts/skills.py validate passes
  • python3 -m unittest discover -s tests -p '*_test.py' passes
  • Sub-skill appears in manifest.json under databricks-serverless-storage-check
  • plugins/databricks/claude/.claude-plugin/plugin.json includes serverless-storage-check keyword
  • Skill loads correctly as a sub-skill of databricks-serverless-migration

This pull request and its description were written by Isaac.

@GabbysCode GabbysCode requested review from a team, lennartkats-db and simonfaltum as code owners May 20, 2026 08:24
@dustinvannoy-db dustinvannoy-db self-requested a review May 27, 2026 17:22
@dustinvannoy-db

Copy link
Copy Markdown
Collaborator

We will reach out directly about possible consolidation of this PR and one of our Field Eng maintainers will add a review once we feel its ready.

@GabbysCode GabbysCode requested a review from a team as a code owner June 5, 2026 12:34
@GabbysCode GabbysCode force-pushed the add-serverless-storage-check branch from 9fcbae3 to a44f32f Compare June 15, 2026 13:40
@jacksandom

Copy link
Copy Markdown

Hi @GabbysCode - can you restructure to match the other skills. So for example, your markdown files should be references for databricks-serverless-migration. Consider if you need 3 md files for this or if we can consolidate?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to remove this and assets as it is captured in the main skill.

GABRIELLE DOMPREH added 5 commits June 23, 2026 15:09
…disk handoffs

Adds a new skill `databricks-serverless-storage-check` that ships an
executable preflight scanner for the antipattern where parent/child
tasks share state through /local_disk0, /tmp, or trustedTemp paths --
the failure seen in serverless jobs that fail with
`INTERNAL_ERROR: [Errno 13] Permission denied` on local-disk paths.

The scanner (scripts/preflight.py, stdlib-only, AST + regex) supports
five input modes (--notebook, --dir, --job-yaml, --job-id, --run-id)
and 7 detection rules (FANOUT001-006 plus ENV001 which routes
env-sync errors to support escalation). All 7 self-tests pass.

Complementary to databricks-serverless-migration (single-notebook
migration). Added a one-line cross-reference from that skill's
data-access table pointing here for multi-task fan-out concerns.

Includes the required agents/openai.yaml (hand-authored) and
SKILL_METADATA entry in scripts/skills.py; manifest regenerated and
`python3 scripts/skills.py validate` passes.

Signed-off-by: GABRIELLE DOMPREH <Gabby.dompreh@databricks.com>
…ruth.yaml

Adds generation_session_id and sources to all four test cases so
stf lint passes cleanly (0 errors, 0 warnings).

Co-authored-by: Isaac
…s-serverless-migration

Moves skills/databricks-serverless-storage-check/ →
skills/databricks-serverless-migration/databricks-serverless-storage-check/
to physically reflect the parent/sub-skill hierarchy.

- Update scripts/skills.py iter_skill_dirs() to yield one level of nested
  skill directories (sub-skills alongside top-level skills)
- Fix relative SKILL.md links: ../databricks-serverless-migration/ → ../
  and ../databricks-{dabs,jobs,core}/ → ../../databricks-{dabs,jobs,core}/
- Fix databricks-serverless-migration/SKILL.md links:
  ../databricks-serverless-storage-check/ → databricks-serverless-storage-check/
- Regenerate manifest.json (skill count unchanged: 9)
- Confirmed: python3 scripts/skills.py validate → Everything is up to date
- Confirmed: stf lint → 0 errors, 0 warnings

Co-authored-by: Isaac
…t skill structure

- Merge pattern-catalog.md + remediation-guide.md into a single
  skills/databricks-serverless-migration/references/serverless-storage-check.md,
  matching how sibling reference docs are structured in the parent skill
- Remove databricks-serverless-storage-check/references/ (now consolidated above)
- Remove databricks-serverless-storage-check/agents/ and assets/ (captured
  at the parent skill level)
- Update SKILL.md links from local references/ to ../references/serverless-storage-check.md
- Regenerate manifest.json

Co-authored-by: Isaac
- Add databricks-serverless-storage-check to metaplugin/plugin.meta.json skills map
- Extend iter_skill_dirs in scripts/skillsgen/discovery.py to yield one level
  of nested sub-skill dirs (scoped to STABLE_REPO_DIR)
- Regenerate manifest.json and all plugins/databricks/ bundles

Co-authored-by: Isaac
@GabbysCode GabbysCode force-pushed the add-serverless-storage-check branch from 4607aa2 to 0253363 Compare June 25, 2026 10:51
…kip codex-metadata for sub-skills

Per reviewer request: sub-skills nested under a parent skill do not need
their own agents/openai.yaml or assets/ — the parent skill covers them.

- Remove agents/ and assets/ from skills/databricks-serverless-migration/databricks-serverless-storage-check/
- Add _is_sub_skill() helper to scripts/skillsgen/discovery.py
- Skip nested sub-skills in ensure_codex_metadata and check_codex_metadata
- Regenerate plugin bundles (12 fewer files per provider)

Co-authored-by: Isaac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants